diff options
author | Eric Wong <e@80x24.org> | 2016-03-17 00:27:36 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2016-03-17 16:35:21 +0000 |
commit | afde9a73a0eafb9c52b3d4ce2911692924ea626e (patch) | |
tree | fc7372d8757db634d44f76ebdb418150e705f218 /Sandbox | |
parent | 735d0f82adcdf9851664136424004dacfbe2423c (diff) | |
download | unicorn-afde9a73a0eafb9c52b3d4ce2911692924ea626e.tar.gz |
"bundle exec" alone is not suitable for use with systemd-style socket activation due to Ruby 2.0+ behavior of setting close-on-exec for file descriptors above 2. However, the "--keep-file-descriptors" option was added to bundler 1.4.0 to workaround this Ruby 2.0 change and may be used to prevent Ruby 2.0+ from closing file descriptors on exec. Thanks to Amir Yalon and Christos Trochalakis for bringing up this issue on the mailing list: http://bogomips.org/unicorn-public/1457824748.3666627.547425122.2A828B07@webmail.messagingengine.com/
Diffstat (limited to 'Sandbox')
-rw-r--r-- | Sandbox | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -63,9 +63,9 @@ before_exec hook as illustrated by https://gist.github.com/534668 === Ruby 2.0.0 close-on-exec and SIGUSR2 incompatibility Ruby 2.0.0 enforces FD_CLOEXEC on file descriptors by default. unicorn -has been prepared for this behavior since unicorn 4.1.0, but we forgot -to remind the Bundler developers. This issue is being tracked here: -https://github.com/bundler/bundler/issues/2628 +has been prepared for this behavior since unicorn 4.1.0, and bundler +needs the "--keep-file-descriptors" option for "bundle exec": +http://bundler.io/man/bundle-exec.1.html == Isolate |