diff options
| author | Eric Wong <e@80x24.org> | 2018-12-26 04:51:31 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2018-12-26 04:51:31 +0000 |
| commit | 2a6cb76d5010cb763ef5a2c305728465d15eb7c9 (patch) | |
| tree | 1dd98b7239f194e0db3102a0f05aacc1707a4f2c /ext/unicorn_http/unicorn_http.rl | |
| parent | 2977d2c6dbb82fb62f2b6ba44687e44a554e2573 (diff) | |
| download | unicorn-2a6cb76d5010cb763ef5a2c305728465d15eb7c9.tar.gz | |
Since Ruby 2.6, it's a documented part of the API and we may depend on it: https://bugs.ruby-lang.org/issues/9894 It's been around since the early Ruby 1.9 days, and reduces overhead compared to relying on rb_global_variable: https://bogomips.org/unicorn-public/20170301002854.29198-1-e@80x24.org/
Diffstat (limited to 'ext/unicorn_http/unicorn_http.rl')
| -rw-r--r-- | ext/unicorn_http/unicorn_http.rl | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/ext/unicorn_http/unicorn_http.rl b/ext/unicorn_http/unicorn_http.rl index 283bfa2..8ef23bc 100644 --- a/ext/unicorn_http/unicorn_http.rl +++ b/ext/unicorn_http/unicorn_http.rl @@ -13,7 +13,7 @@ #include "global_variables.h" #include "c_util.h" -void init_unicorn_httpdate(VALUE mark_ary); +void init_unicorn_httpdate(void); #define UH_FL_CHUNKED 0x1 #define UH_FL_HASBODY 0x2 @@ -931,11 +931,8 @@ static VALUE HttpParser_rssget(VALUE self) void Init_unicorn_http(void) { - static VALUE mark_ary; VALUE mUnicorn, cHttpParser; - mark_ary = rb_ary_new(); - rb_global_variable(&mark_ary); mUnicorn = rb_define_module("Unicorn"); cHttpParser = rb_define_class_under(mUnicorn, "HttpParser", rb_cObject); eHttpParserError = @@ -945,7 +942,7 @@ void Init_unicorn_http(void) e414 = rb_define_class_under(mUnicorn, "RequestURITooLongError", eHttpParserError); - init_globals(mark_ary); + init_globals(); rb_define_alloc_func(cHttpParser, HttpParser_alloc); rb_define_method(cHttpParser, "initialize", HttpParser_init, 0); rb_define_method(cHttpParser, "clear", HttpParser_clear, 0); @@ -982,16 +979,14 @@ void Init_unicorn_http(void) rb_define_singleton_method(cHttpParser, "max_header_len=", set_maxhdrlen, 1); - init_common_fields(mark_ary); + init_common_fields(); SET_GLOBAL(g_http_host, "HOST"); SET_GLOBAL(g_http_trailer, "TRAILER"); SET_GLOBAL(g_http_transfer_encoding, "TRANSFER_ENCODING"); SET_GLOBAL(g_content_length, "CONTENT_LENGTH"); SET_GLOBAL(g_http_connection, "CONNECTION"); id_set_backtrace = rb_intern("set_backtrace"); - init_unicorn_httpdate(mark_ary); - - OBJ_FREEZE(mark_ary); + init_unicorn_httpdate(); #ifndef HAVE_RB_HASH_CLEAR id_clear = rb_intern("clear"); |