* [PATCH] Properly override respond_to? in Raindrops::Middleware::Proxy
@ 2017-07-25 20:02 Dmytro Shteflyuk
2017-07-25 21:38 ` Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Dmytro Shteflyuk @ 2017-07-25 20:02 UTC (permalink / raw)
To: raindrops-public; +Cc: Dmytro Shteflyuk
Correct method definition according to Ruby documentation (https://ruby-doc.org/core-2.4.1/Object.html#method-i-respond_to-3F) is:
respond_to?(string, include_all=false) → true or false
Rack started using second argument starting from version 2:
https://github.com/rack/rack/blob/master/lib/rack/body_proxy.rb#L14
If raindrops is used in Rack 2+ applications, an exception is raised:
ArgumentError: wrong number of arguments (2 for 1)
<ROOT>/gems/raindrops-0.18.0/lib/raindrops/middleware/proxy.rb:30:in `respond_to?'
<ROOT>/gems/rack-2.0.3/lib/rack/body_proxy.rb:14:in `respond_to?'
---
lib/raindrops/middleware/proxy.rb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/raindrops/middleware/proxy.rb b/lib/raindrops/middleware/proxy.rb
index 1cf437c..a7c8e66 100644
--- a/lib/raindrops/middleware/proxy.rb
+++ b/lib/raindrops/middleware/proxy.rb
@@ -27,9 +27,9 @@ def to_path
# Rack servers use +respond_to?+ to check for the presence of +close+
# and +to_path+ methods.
- def respond_to?(m)
+ def respond_to?(m, include_all = false)
m = m.to_sym
- :close == m || @body.respond_to?(m)
+ :close == m || @body.respond_to?(m, include_all)
end
# Avoid breaking users of non-standard extensions (e.g. #body)
--
2.13.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-25 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-25 20:02 [PATCH] Properly override respond_to? in Raindrops::Middleware::Proxy Dmytro Shteflyuk
2017-07-25 21:38 ` Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/raindrops.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).