posix_mq RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: ruby-posix-mq@bogomips.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] drop extra args to rb_funcall
Date: Tue, 30 Jan 2018 23:58:33 +0000	[thread overview]
Message-ID: <20180130235833.14952-1-e@80x24.org> (raw)

This was harmless in Ruby 2.4, but Ruby 2.5 with newer versions
of clang are not happy about it.  Eventually this may be fixed
in Ruby 2.5.1: https://bugs.ruby-lang.org/issues/14425
---
 ext/posix_mq/posix_mq.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ext/posix_mq/posix_mq.c b/ext/posix_mq/posix_mq.c
index 4ba7d7c..6a5439b 100644
--- a/ext/posix_mq/posix_mq.c
+++ b/ext/posix_mq/posix_mq.c
@@ -907,7 +907,7 @@ static int lookup_sig(VALUE sig)
 	if (!list) {
 		VALUE mSignal = rb_const_get(rb_cObject, rb_intern("Signal"));
 
-		list = rb_funcall(mSignal, rb_intern("list"), 0, 0);
+		list = rb_funcall(mSignal, rb_intern("list"), 0);
 		rb_obj_freeze(list);
 		rb_global_variable(&list);
 	}
@@ -961,7 +961,7 @@ static void lower_stack_size(pthread_attr_t *attr)
 /* :nodoc: */
 static VALUE setnotify_exec(VALUE self, VALUE io, VALUE thr)
 {
-	int fd = NUM2INT(rb_funcall(io, id_fileno, 0, 0));
+	int fd = NUM2INT(rb_funcall(io, id_fileno, 0));
 	struct posix_mq *mq = get(self, 1);
 	struct sigevent not;
 	pthread_attr_t attr;
@@ -979,7 +979,7 @@ static VALUE setnotify_exec(VALUE self, VALUE io, VALUE thr)
 	not.sigev_value.sival_int = fd;
 
 	if (!NIL_P(mq->thread))
-		rb_funcall(mq->thread, id_kill, 0, 0);
+		rb_funcall(mq->thread, id_kill, 0);
 	mq->thread = thr;
 
 	my_mq_notify(mq->des, &not);
@@ -993,7 +993,7 @@ static VALUE notify_cleanup(VALUE self)
 	struct posix_mq *mq = get(self, 1);
 
 	if (!NIL_P(mq->thread)) {
-		rb_funcall(mq->thread, id_kill, 0, 0);
+		rb_funcall(mq->thread, id_kill, 0);
 		mq->thread = Qnil;
 	}
 	return Qnil;
-- 
EW


                 reply	other threads:[~2018-01-30 23:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/ruby_posix_mq/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130235833.14952-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=ruby-posix-mq@bogomips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/ruby_posix_mq.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).