* [PATCH] http_request: freeze constant strings passed IO#write
@ 2017-02-13 18:27 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-02-13 18:27 UTC (permalink / raw)
To: unicorn-public
This ensures we won't have duplicate objects in Ruby 2.0-2.4.
For Ruby 2.5.0dev+, this avoids any duplicate cleanup
introduced as of r57471: https://bugs.ruby-lang.org/issues/13085
---
lib/unicorn/http_request.rb | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lib/unicorn/http_request.rb b/lib/unicorn/http_request.rb
index 0c1f9bb..c176083 100644
--- a/lib/unicorn/http_request.rb
+++ b/lib/unicorn/http_request.rb
@@ -24,10 +24,7 @@ class Unicorn::HttpParser
NULL_IO = StringIO.new("")
# :stopdoc:
- # A frozen format for this is about 15% faster
- # Drop these frozen strings when Ruby 2.2 becomes more prevalent,
- # 2.2+ optimizes hash assignments when used with literal string keys
- HTTP_RESPONSE_START = [ 'HTTP', '/1.1 ']
+ HTTP_RESPONSE_START = [ 'HTTP'.freeze, '/1.1 '.freeze ]
@@input_class = Unicorn::TeeInput
@@check_client_connection = false
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-13 18:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-13 18:27 [PATCH] http_request: freeze constant strings passed IO#write Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).