From: Eric Wong <bofh@yhbt.net>
To: unicorn-public@yhbt.net
Subject: Re: [RFC 0-3/3] depend on Ruby 2.5+, eliminate kgio
Date: Wed, 4 Oct 2023 03:06:59 +0000 [thread overview]
Message-ID: <20231004030659.M341393@dcvr> (raw)
In-Reply-To: <20230905094420.M199613@dcvr>
Eric Wong <bofh@yhbt.net> wrote:
> Patch 2/3 could use an extra set of eyes since it's fairly big,
> but passes all tests.
Any comments? Anybody still on Ruby <= 2.4?
> + filter_body(once = '', @socket.readpartial(@@io_chunk_size, @buf))
> +++ b/lib/unicorn/http_request.rb
> @@ -61,7 +61,7 @@ def self.check_client_connection=(bool)
> # returns an environment hash suitable for Rack if successful
> # This does minimal exception trapping and it is up to the caller
> # to handle any socket errors (e.g. user aborted upload).
> - def read(socket)
> + def read_headers(socket, ai)
O_O OMG we haz AI now! Think of the marketing potential!
Disclaimer: I have never and will never use any form of
intelligence (artificial or otherwise) in writing unicorn.
prev parent reply other threads:[~2023-10-04 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 9:44 [RFC 0-3/3] depend on Ruby 2.5+, eliminate kgio Eric Wong
2023-10-04 3:06 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004030659.M341393@dcvr \
--to=bofh@yhbt.net \
--cc=unicorn-public@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).