* [PATCH] dev.c: fail gracefully on out-of-memory errors
@ 2015-08-17 6:00 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-08-17 6:00 UTC (permalink / raw)
To: cmogstored-public
The rest of cmogstored shall be updated to fail gracefully on OOM
in due time. It may take a while, since not many systems encounter
this, but we shall become more robust as time goes on.
---
dev.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/dev.c b/dev.c
index cd14db9..5b3888b 100644
--- a/dev.c
+++ b/dev.c
@@ -169,8 +169,17 @@ int mog_dev_mkusage(const struct mog_dev *dev, struct mog_svc *svc)
if (!svc->mgmt_mfd)
return 0;
- usage_path = xasprintf("/dev%u/usage", (unsigned)dev->devid);
- tmp_path = xasprintf("%s.%x", usage_path, (unsigned)getpid());
+ if (asprintf(&usage_path, "/dev%u/usage", (unsigned)dev->devid) < 0) {
+ syslog(LOG_ERR, "error generating path: /dev%u/usage (%m)",
+ (unsigned)dev->devid);
+ return 0;
+ }
+ if (asprintf(&tmp_path, "%s.%x", usage_path, (unsigned)getpid()) < 0) {
+ syslog(LOG_ERR, "error generating path: /dev%u/usage.%u (%m)",
+ (unsigned)dev->devid, (unsigned)getpid());
+ free(usage_path);
+ return 0;
+ }
if (mog_unlink(svc, tmp_path) < 0 && errno != ENOENT) goto out;
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-08-17 6:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-17 6:00 [PATCH] dev.c: fail gracefully on out-of-memory errors Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/cmogstored.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).