about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-05-11 07:50:22 +0000
committerEric Wong <e@80x24.org>2019-05-11 07:54:31 +0000
commitaf80cb709474cac2eaae29bf33facdc9e13af20d (patch)
treede89d47132a83d7e0b5b86e1322a63965b18f0cd
parent79b949e62b8a6f6f0047edcd2bf20970481a94b1 (diff)
downloadcmogstored-af80cb709474cac2eaae29bf33facdc9e13af20d.tar.gz
The bugfix should hit mainline and stable kernels, soon; but
there's no reason for us to be caring if errno is EINTR, or
not...

https://lore.kernel.org/lkml/20190427093319.sgicqik2oqkez3wk@dcvr/
https://lore.kernel.org/lkml/20190507043954.9020-1-deepa.kernel@gmail.com/
-rw-r--r--notify.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/notify.c b/notify.c
index 73e772a..1deed82 100644
--- a/notify.c
+++ b/notify.c
@@ -100,7 +100,14 @@ void mog_notify_wait(bool need_usage_file)
         mfd = mog_idleq_wait_intr(mog_notify_queue, timeout);
         if (mfd)
                 notify_queue_step(mfd);
-        else if (errno == EINTR)
+        else
+                /*
+                 * errno == EINTR, but epoll_pwait on some Linux v5.0+/v5.1+
+                 * fails to return EINTR.  This should be fixed in Linux,
+                 * soon:
+                 * <20190427093319.sgicqik2oqkez3wk@dcvr>
+                 * <20190507043954.9020-1-deepa.kernel@gmail.com>
+                 */
                 note_run();
 }