diff options
author | Eric Wong <e@80x24.org> | 2016-12-29 07:31:40 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2016-12-29 07:31:40 +0000 |
commit | 8307157e7381f24b2833d3e3fdf084555265f420 (patch) | |
tree | 504aade3405a391d222b77571b145e8322dc2829 | |
parent | 6f35eb68c0b45aa64da442022cda82b7df9194c4 (diff) | |
download | mogilefs-client-8307157e7381f24b2833d3e3fdf084555265f420.tar.gz |
None of these are too performance critical, but err on the safe side and avoid allocations whenever possible.
-rw-r--r-- | lib/mogilefs/http_file.rb | 2 | ||||
-rw-r--r-- | lib/mogilefs/new_file/stream.rb | 8 | ||||
-rw-r--r-- | lib/mogilefs/new_file/writer.rb | 2 |
3 files changed, 6 insertions, 6 deletions
diff --git a/lib/mogilefs/http_file.rb b/lib/mogilefs/http_file.rb index caf85ca..c7949a5 100644 --- a/lib/mogilefs/http_file.rb +++ b/lib/mogilefs/http_file.rb @@ -143,7 +143,7 @@ class MogileFS::HTTPFile < StringIO end put = Net::HTTP::Put.new(uri.path) - put["Content-Type"] = "application/octet-stream" + put["Content-Type"] = "application/octet-stream".freeze if md5 = @opts[:content_md5] if md5.respond_to?(:call) md5 = md5.call.strip diff --git a/lib/mogilefs/new_file/stream.rb b/lib/mogilefs/new_file/stream.rb index 71ac591..195b121 100644 --- a/lib/mogilefs/new_file/stream.rb +++ b/lib/mogilefs/new_file/stream.rb @@ -66,7 +66,7 @@ class MogileFS::NewFile::Stream def start_sock(sock, uri) host_with_port = "#{uri.host}:#{uri.port}" headers = "PUT #{uri.request_uri} HTTP/1.1\r\n" \ - "Host: #{host_with_port}\r\n" \ + "Host: #{host_with_port}\r\n" content_md5 = @opts[:content_md5] if String === content_md5 @@ -75,16 +75,16 @@ class MogileFS::NewFile::Stream :trailer == content_md5 || MD5_TRAILER_NODES[host_with_port] @md5 = Digest::MD5.new - headers << "Trailer: Content-MD5\r\n" + headers << "Trailer: Content-MD5\r\n".freeze end if ! @md5 && clen = @opts[:content_length] headers << "Content-Length: #{clen}\r\n" else - headers << "Transfer-Encoding: chunked\r\n" + headers << "Transfer-Encoding: chunked\r\n".freeze end - sock.write(headers << "\r\n") + sock.write(headers << "\r\n".freeze) end alias syswrite write diff --git a/lib/mogilefs/new_file/writer.rb b/lib/mogilefs/new_file/writer.rb index d58a4e6..e2f13fc 100644 --- a/lib/mogilefs/new_file/writer.rb +++ b/lib/mogilefs/new_file/writer.rb @@ -9,7 +9,7 @@ module MogileFS::NewFile::Writer def puts(*args) args.each do |obj| write(obj) - write("\n") + write("\n".freeze) end nil end |