io_splice RubyGem user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: ruby.io.splice@librelist.org
Subject: [PATCH] vmsplice: avoid referencing invalid stack address for strings
Date: Sat, 19 Jan 2013 04:54:07 +0000	[thread overview]
Message-ID: <20130119045407.GA3433@dcvr.yhbt.net> (raw)
In-Reply-To: <20130119045407.GA3433@dcvr.yhbt.net>

Newer GCC more aggressively optimizes stack allocations away,
so we need to avoid passing out-of-scope addresses to vmsplice.
Not that vmsplice is useful in Ruby...
---
 pushed to "master" of git://bogomips.org/ruby_io_splice

 ext/io_splice/io_splice_ext.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/ext/io_splice/io_splice_ext.c b/ext/io_splice/io_splice_ext.c
index 32de838..876d07d 100644
--- a/ext/io_splice/io_splice_ext.c
+++ b/ext/io_splice/io_splice_ext.c
@@ -492,19 +492,18 @@ static VALUE my_vmsplice(int argc, VALUE * argv, VALUE self)
 	ssize_t rv = 0;
 	ssize_t left;
 	struct vmsplice_args a;
+	struct iovec iov;
+
 	VALUE io, data, flags;
 
 	rb_scan_args(argc, argv, "21", &io, &data, &flags);
 
 	switch (TYPE(data)) {
-	case T_STRING: {
-		struct iovec iov;
-
+	case T_STRING:
 		iov.iov_base = RSTRING_PTR(data);
 		iov.iov_len = (size_t)(left = (ssize_t)RSTRING_LEN(data));
 		a.iov = &iov;
 		a.nr_segs = 1;
-		}
 		break;
 	case T_ARRAY:
 		ARY2IOVEC(a.iov, a.nr_segs, left, data);
-- 
Eric Wong


           reply	other threads:[~2013-01-19  4:54 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20130119045407.GA3433@dcvr.yhbt.net>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/ruby_io_splice/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130119045407.GA3433@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=ruby.io.splice@librelist.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/ruby_io_splice.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).