* [PATCH] epoll: allow :CLOEXEC instead of the long constant
@ 2015-06-05 9:26 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2015-06-05 9:26 UTC (permalink / raw)
To: sleepy-penguin; +Cc: Eric Wong
The long constant name conveys no additional info. Since
epoll_create1 is rarely called, and a cache lookup for cold
code is wasfeful
---
ext/sleepy_penguin/epoll.c | 2 +-
test/test_epoll.rb | 7 +++++++
test/test_epoll_io.rb | 2 +-
3 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/ext/sleepy_penguin/epoll.c b/ext/sleepy_penguin/epoll.c
index 423ed69..120af0c 100644
--- a/ext/sleepy_penguin/epoll.c
+++ b/ext/sleepy_penguin/epoll.c
@@ -82,7 +82,7 @@ static struct ep_per_thread *ept_get(VALUE self, int maxevents)
static VALUE s_new(VALUE klass, VALUE _flags)
{
int default_flags = RB_SP_CLOEXEC(EPOLL_CLOEXEC);
- int flags = rb_sp_get_flags(klass, _flags, default_flags);
+ int flags = rb_sp_get_flags(cEpoll, _flags, default_flags);
int fd = epoll_create1(flags);
VALUE rv;
diff --git a/test/test_epoll.rb b/test/test_epoll.rb
index 61b6e8c..48dd0ad 100644
--- a/test/test_epoll.rb
+++ b/test/test_epoll.rb
@@ -343,6 +343,13 @@ class TestEpoll < Testcase
@ep.close
io = Epoll.new(Epoll::CLOEXEC).to_io
assert((io.fcntl(Fcntl::F_GETFD) & Fcntl::FD_CLOEXEC) == Fcntl::FD_CLOEXEC)
+ io.close
+
+ # prettier, slower, but more memory efficient due to lack of caching
+ # due to the constant cache:
+ io = Epoll.new(:CLOEXEC).to_io
+
+ assert((io.fcntl(Fcntl::F_GETFD) & Fcntl::FD_CLOEXEC) == Fcntl::FD_CLOEXEC)
end
def test_new
diff --git a/test/test_epoll_io.rb b/test/test_epoll_io.rb
index 56a3808..5452de1 100644
--- a/test/test_epoll_io.rb
+++ b/test/test_epoll_io.rb
@@ -23,7 +23,7 @@ class TestEpollIO < Testcase
class EpSub < Epoll::IO
def self.new
- super(SleepyPenguin::Epoll::CLOEXEC)
+ super(:CLOEXEC)
end
end
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-06-05 9:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-05 9:26 [PATCH] epoll: allow :CLOEXEC instead of the long constant Eric Wong
Code repositories for project(s) associated with this public inbox
https://yhbt.net/sleepy_penguin.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).