From: Eric Wong <normalperson@yhbt.net>
To: sleepy.penguin@librelist.org
Subject: Re: [sleepy.penguin] [PATCH] Support for broken system without clock_gettime.
Date: Tue, 24 Sep 2013 21:05:07 +0000 [thread overview]
Message-ID: <20130924210507.GA10409@dcvr.yhbt.net> (raw)
In-Reply-To: <CAA2_N1sLL_cpTjR-BF86p+sn9QbXO06GJdqNG-A9YcJ9bMmRbA@mail.gmail.com>
"Lin Jen-Shin (godfat)" <godfat@godfat.org> wrote:
> On Wed, Sep 25, 2013 at 2:09 AM, Eric Wong <normalperson@yhbt.net> wrote:
> > Lin Jen-Shin <godfat@godfat.org> wrote:
> > Pushed with the following commit addendum:
> [...]
>
> Thank you!
Thank you for the patch!
> > I'm not sure why you switched to spaces for indentation. I just changed
> > it back to match the original clogger code.
> > (my preferred C indentation style is based on Linux kernel conventions)
>
> Doh! I am sorry for that, it's a mistake. Usually I would just follow the
> original coding style. I guess I might be too tired recently so was not
> careful enough this time :/
No worries. Btw, do you have time to run/write more tests for the
kqueue code? I think the RARRAY_PTR usage should be replaced with newer
RARRAY_* macros or even just rb_ary_entry in some places for 2.1.0 and
rbx.
(ref: comments in https://bugs.ruby-lang.org/issues/8399)
next prev parent reply other threads:[~2013-09-24 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 8:55 [sleepy.penguin] [PATCH] Support for broken system without clock_gettime Lin Jen-Shin
2013-09-24 18:09 ` Eric Wong
2013-09-24 18:15 ` Lin Jen-Shin (godfat)
2013-09-24 21:05 ` Eric Wong [this message]
2013-09-25 11:43 ` Lin Jen-Shin (godfat)
2013-09-25 17:37 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/sleepy_penguin/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924210507.GA10409@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=sleepy.penguin@librelist.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/sleepy_penguin.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).