From: "Lin Jen-Shin (godfat)" <godfat@godfat.org>
To: sleepy.penguin@librelist.org
Subject: Re: [sleepy.penguin] [PATCH] Support for broken system without clock_gettime.
Date: Wed, 25 Sep 2013 19:43:06 +0800 [thread overview]
Message-ID: <CAA2_N1sWjJg83snXVjVqvZh+a_Z4-_=Y5Q80go8=w6RroH-1yA@mail.gmail.com> (raw)
In-Reply-To: 20130924210507.GA10409@dcvr.yhbt.net
On Wed, Sep 25, 2013 at 5:05 AM, Eric Wong <normalperson@yhbt.net> wrote:
> No worries. Btw, do you have time to run/write more tests for the
> kqueue code? I think the RARRAY_PTR usage should be replaced with newer
> RARRAY_* macros or even just rb_ary_entry in some places for 2.1.0 and
> rbx.
>
> (ref: comments in https://bugs.ruby-lang.org/issues/8399)
Would be my pleasure to do so, though maybe not in a day or two.
On the other hand, since I only wrote some naive C extensions
for Ruby from copying and pasting, (i.e. readline_buffer
https://github.com/godfat/readline_buffer )
I don't know why sometimes the API is in the form of macro
and sometimes in the form of function. According to my
C experience, I would prefer to use functions.
Is there any reason why we need macros for some functions?
To inline function calls before C99?
And do we need Ruby version guards at places if some
Ruby API is missing for older Ruby? Or just like how we
did for clock_gettime?
next prev parent reply other threads:[~2013-09-25 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 8:55 [sleepy.penguin] [PATCH] Support for broken system without clock_gettime Lin Jen-Shin
2013-09-24 18:09 ` Eric Wong
2013-09-24 18:15 ` Lin Jen-Shin (godfat)
2013-09-24 21:05 ` Eric Wong
2013-09-25 11:43 ` Lin Jen-Shin (godfat) [this message]
2013-09-25 17:37 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/sleepy_penguin/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA2_N1sWjJg83snXVjVqvZh+a_Z4-_=Y5Q80go8=w6RroH-1yA@mail.gmail.com' \
--to=godfat@godfat.org \
--cc=sleepy.penguin@librelist.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/sleepy_penguin.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).