unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: query string max length tweak ?
Date: Thu, 23 Jun 2011 11:37:32 -0700	[thread overview]
Message-ID: <20110623183732.GA12651@dcvr.yhbt.net> (raw)
In-Reply-To: <BANLkTi=yME+NP9_XnfVFxwGJRNnKW0=uBw@mail.gmail.com>

Mohit Chawla <mohit.chawla.binary@gmail.com> wrote:
> Hi,
> 
> Is there a way that would allow us to increase the max length allowed
> for query_string ? We have been getting 414s on large GET requests. We
> are running the puppet master under unicorn behind nginx. I am not
> sure of the general implications of this, whether its suggested/safe
> even, but it is somewhat of a necessity. Any suggestions ?

You can change the following lines in ext/unicorn/global_variables.h
and rebuild the parser:

  DEF_MAX_LENGTH(REQUEST_URI, 1024 * 12);
  ...
  DEF_MAX_LENGTH(QUERY_STRING, (1024 * 10));

There's currently no way to configure them otherwise, but I can consider
dropping these per-field limits entirely.  We now have a config option
to set the maximum header size (only exposed via Rainbows!, though).

This means we would only care about the size of the entire header, and
not the size of any individual element.  I consider the size of the
entire header more important anyways.  We currently don't have
limits on the number of headers that can be sent.

-- 
Eric Wong
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


  reply	other threads:[~2011-06-23 19:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-23 16:36 query string max length tweak ? Mohit Chawla
2011-06-23 18:37 ` Eric Wong [this message]
2011-06-23 19:31   ` Mohit Chawla
2011-06-24  0:38     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110623183732.GA12651@dcvr.yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).