unicorn Ruby/Rack server user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Mohit Chawla <mohit.chawla.binary@gmail.com>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: query string max length tweak ?
Date: Fri, 24 Jun 2011 01:01:10 +0530	[thread overview]
Message-ID: <BANLkTinCsg0ZQBboFRXojafrFhdSQoD0zA@mail.gmail.com> (raw)
In-Reply-To: <20110623183732.GA12651@dcvr.yhbt.net>

Hi,

On Fri, Jun 24, 2011 at 12:07 AM, Eric Wong <normalperson@yhbt.net> wrote:
> You can change the following lines in ext/unicorn/global_variables.h
> and rebuild the parser:
>
>  DEF_MAX_LENGTH(REQUEST_URI, 1024 * 12);
>  ...
>  DEF_MAX_LENGTH(QUERY_STRING, (1024 * 10));
>
> There's currently no way to configure them otherwise, but I can consider
> dropping these per-field limits entirely.  We now have a config option
> to set the maximum header size (only exposed via Rainbows!, though).
>
> This means we would only care about the size of the entire header, and
> not the size of any individual element.  I consider the size of the
> entire header more important anyways.  We currently don't have
> limits on the number of headers that can be sent.

Thanks a lot, yes I was trying out changing only the QUERY_STRING max
length, but that wasn't working. Will change the REQUEST_URI max
length as well. Also, I am new to using unicorn, hence not aware if
using Rainbows! in this scenario can be achieved/is suggested ? Nice
to know about limiting the entire size header in future releases ( in
prod we are using 1.1.4 ! ).

Also, sorry for the multiple html mails before this !
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying


  reply	other threads:[~2011-06-23 19:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-23 16:36 query string max length tweak ? Mohit Chawla
2011-06-23 18:37 ` Eric Wong
2011-06-23 19:31   ` Mohit Chawla [this message]
2011-06-24  0:38     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://yhbt.net/unicorn/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinCsg0ZQBboFRXojafrFhdSQoD0zA@mail.gmail.com \
    --to=mohit.chawla.binary@gmail.com \
    --cc=mongrel-unicorn@rubyforge.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhbt.net/unicorn.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).