From: Eric Wong <normalperson@yhbt.net>
To: unicorn list <mongrel-unicorn@rubyforge.org>
Cc: Lin Jen-Shin <godfat@godfat.org>
Subject: Re: [PATCH] Add -N or --no-default-middleware option.
Date: Tue, 29 Jan 2013 04:02:20 +0000 [thread overview]
Message-ID: <20130129040220.GA30278@dcvr.yhbt.net> (raw)
In-Reply-To: <20130129035231.GA27702@dcvr.yhbt.net>
Eric Wong <normalperson@yhbt.net> wrote:
> Lin Jen-Shin <godfat@godfat.org> wrote:
> > + opts.on("-N", "--no-default-middleware",
> > + "no default middleware even if RACK_ENV is development") do |e|
>
> RACK_ENV=deployment also loads middleware, so I think it's more accurate
> with:
>
> do not load middleware implied by RACK_ENV
>
> This also puts us back within the 80-column limit imposed by "test_help"
> in test/exec/test_exec.rb
Heh, turns out there's a bug in test_exec.rb (but I still don't think
mentioning "development" for this help is correct)
>From ee3ada3c697311ab0a799fcdc492ae062e7d5128 Mon Sep 17 00:00:00 2001
From: Eric Wong <normalperson@yhbt.net>
Date: Tue, 29 Jan 2013 03:56:16 +0000
Subject: [PATCH] test_exec: do not count '\n' as column width
This off-by-one error was incorrectly rejecting a line which
would've been readable without wrapping on an 80-column terminal.
---
test/exec/test_exec.rb | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/exec/test_exec.rb b/test/exec/test_exec.rb
index 1cee2b7..10a1bae 100644
--- a/test/exec/test_exec.rb
+++ b/test/exec/test_exec.rb
@@ -323,6 +323,7 @@ EOF
# mobile phone or netbook on a slow connection :)
assert lines.size <= 24, "help height fits in an ANSI terminal window"
lines.each do |line|
+ line.chomp!
assert line.size <= 80, "help width fits in an ANSI terminal window"
end
end
--
1.8.1.1.253.g2934a48
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
next prev parent reply other threads:[~2013-01-29 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 3:21 [PATCH] Add -N or --no-default-middleware option Lin Jen-Shin
2013-01-29 3:52 ` Eric Wong
2013-01-29 4:02 ` Eric Wong [this message]
2013-01-29 4:03 ` Lin Jen-Shin (godfat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129040220.GA30278@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=godfat@godfat.org \
--cc=mongrel-unicorn@rubyforge.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).