From: "Lin Jen-Shin (godfat)" <godfat@godfat.org>
To: Eric Wong <normalperson@yhbt.net>
Cc: unicorn list <mongrel-unicorn@rubyforge.org>
Subject: Re: [PATCH] Add -N or --no-default-middleware option.
Date: Tue, 29 Jan 2013 12:03:59 +0800 [thread overview]
Message-ID: <CAA2_N1uJo8YdUv44w0imo38xSf+A086UD56KKT+DnOk9CEj_EQ@mail.gmail.com> (raw)
In-Reply-To: <20130129035231.GA27702@dcvr.yhbt.net>
On Tue, Jan 29, 2013 at 11:52 AM, Eric Wong <normalperson@yhbt.net> wrote:
> Lin Jen-Shin <godfat@godfat.org> wrote:
>> + opts.on("-N", "--no-default-middleware",
>> + "no default middleware even if RACK_ENV is development") do |e|
>
> RACK_ENV=deployment also loads middleware, so I think it's more accurate
> with:
>
> do not load middleware implied by RACK_ENV
>
> This also puts us back within the 80-column limit imposed by "test_help"
> in test/exec/test_exec.rb
Oh right, I only remembered to keep the source within 80-column limit,
but forgot that the output might be longer than source. Thanks for the
better wordings. I updated the patch for Zbatery, but it's too late
for Rainbows though.
> Will sign-off and push that change squashed unless there are objections.
Surely, thanks!
> I also just bumped master to rack 1.5.1, which fixes the Rack::Lint
> test regression in 1.5.0.
>
> Will pull in the "hijack" branch into master soon (and release 4.6.0)
> since all my questions about it have been answered in rack-devel.
I haven't had a chance to read hijack more, looking forward to it :)
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying
prev parent reply other threads:[~2013-01-29 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 3:21 [PATCH] Add -N or --no-default-middleware option Lin Jen-Shin
2013-01-29 3:52 ` Eric Wong
2013-01-29 4:02 ` Eric Wong
2013-01-29 4:03 ` Lin Jen-Shin (godfat) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://yhbt.net/unicorn/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA2_N1uJo8YdUv44w0imo38xSf+A086UD56KKT+DnOk9CEj_EQ@mail.gmail.com \
--to=godfat@godfat.org \
--cc=mongrel-unicorn@rubyforge.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhbt.net/unicorn.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).