[RFC] oobgc: link to Aman's gctools for Ruby 2.1+

[RFC] oobgc: link to Aman's gctools for Ruby 2.1+

[Eric Wong]

I've never liked OobGC, so "hot potato!" :)
---
 I'll push this sometime this weekend.
 Corrections/edits/acks/nacks welcome.

 lib/unicorn/oob_gc.rb | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lib/unicorn/oob_gc.rb b/lib/unicorn/oob_gc.rb
index 4e78a70..4cddd50 100644
--- a/lib/unicorn/oob_gc.rb
+++ b/lib/unicorn/oob_gc.rb
@@ -1,5 +1,11 @@
 # -*- encoding: binary -*-
 
+# Strongly consider https://github.com/tmm1/gctools if using Ruby 2.1+
+# It is built on new APIs in Ruby 2.1, so it is more intelligent than
+# this historical implementation.
+#
+# The following information is only for historical versions of Ruby.
+#
 # Runs GC after requests, after closing the client socket and
 # before attempting to accept more connections.
 #
-- 
EW

_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying

Re: [RFC] oobgc: link to Aman's gctools for Ruby 2.1+

[Aman Gupta]

Fine by me.

On Fri, Mar 28, 2014 at 6:35 PM, Eric Wong <e@80x24.org> wrote:
> I've never liked OobGC, so "hot potato!" :)
> ---
>  I'll push this sometime this weekend.
>  Corrections/edits/acks/nacks welcome.
>
>  lib/unicorn/oob_gc.rb | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/lib/unicorn/oob_gc.rb b/lib/unicorn/oob_gc.rb
> index 4e78a70..4cddd50 100644
> --- a/lib/unicorn/oob_gc.rb
> +++ b/lib/unicorn/oob_gc.rb
> @@ -1,5 +1,11 @@
>  # -*- encoding: binary -*-
>
> +# Strongly consider https://github.com/tmm1/gctools if using Ruby 2.1+
> +# It is built on new APIs in Ruby 2.1, so it is more intelligent than
> +# this historical implementation.
> +#
> +# The following information is only for historical versions of Ruby.
> +#
>  # Runs GC after requests, after closing the client socket and
>  # before attempting to accept more connections.
>  #
> --
> EW
>
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying

Re: [RFC] oobgc: link to Aman's gctools for Ruby 2.1+

[Sam Saffron]

Perhaps link to
https://github.com/discourse/discourse/blob/master/lib/middleware/unicorn_oobgc.rb
for a 2.0 compatible solution (for people not on 2.1 yet)

On Sat, Mar 29, 2014 at 12:35 PM, Eric Wong <e@80x24.org> wrote:
> I've never liked OobGC, so "hot potato!" :)
> ---
>  I'll push this sometime this weekend.
>  Corrections/edits/acks/nacks welcome.
>
>  lib/unicorn/oob_gc.rb | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/lib/unicorn/oob_gc.rb b/lib/unicorn/oob_gc.rb
> index 4e78a70..4cddd50 100644
> --- a/lib/unicorn/oob_gc.rb
> +++ b/lib/unicorn/oob_gc.rb
> @@ -1,5 +1,11 @@
>  # -*- encoding: binary -*-
>
> +# Strongly consider https://github.com/tmm1/gctools if using Ruby 2.1+
> +# It is built on new APIs in Ruby 2.1, so it is more intelligent than
> +# this historical implementation.
> +#
> +# The following information is only for historical versions of Ruby.
> +#
>  # Runs GC after requests, after closing the client socket and
>  # before attempting to accept more connections.
>  #
> --
> EW
>
> _______________________________________________
> Unicorn mailing list - mongrel-unicorn@rubyforge.org
> http://rubyforge.org/mailman/listinfo/mongrel-unicorn
> Do not quote signatures (like this one) or top post when replying
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying

Re: [RFC] oobgc: link to Aman's gctools for Ruby 2.1+

[Eric Wong]

Sam Saffron <sam.saffron@gmail.com> wrote:
> Perhaps link to
> https://github.com/discourse/discourse/blob/master/lib/middleware/unicorn_oobgc.rb
> for a 2.0 compatible solution (for people not on 2.1 yet)

OK.  I prefer to link to the repo homepage/root to give the top-level
project more visibility and also avoid long URLs.

How about this?

--- a/lib/unicorn/oob_gc.rb
+++ b/lib/unicorn/oob_gc.rb
@@ -4,6 +4,10 @@
 # It is built on new APIs in Ruby 2.1, so it is more intelligent than
 # this historical implementation.
 #
+# Users on Ruby 2.0 (not 2.1+) may also want to check out
+# lib/middleware/unicorn_oobgc.rb from the Discourse project
+# (https://github.com/discourse/discourse)
+#
 # The following information is only for historical versions of Ruby.
 #
 # Runs GC after requests, after closing the client socket and
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying

Re: [RFC] oobgc: link to Aman's gctools for Ruby 2.1+

[Sam Saffron]

Looks perfect to me. Thanks heaps

On Wed, Apr 2, 2014 at 8:55 PM, Eric Wong <normalperson@yhbt.net> wrote:
> Sam Saffron <sam.saffron@gmail.com> wrote:
>> Perhaps link to
>> https://github.com/discourse/discourse/blob/master/lib/middleware/unicorn_oobgc.rb
>> for a 2.0 compatible solution (for people not on 2.1 yet)
>
> OK.  I prefer to link to the repo homepage/root to give the top-level
> project more visibility and also avoid long URLs.
>
> How about this?
>
> --- a/lib/unicorn/oob_gc.rb
> +++ b/lib/unicorn/oob_gc.rb
> @@ -4,6 +4,10 @@
>  # It is built on new APIs in Ruby 2.1, so it is more intelligent than
>  # this historical implementation.
>  #
> +# Users on Ruby 2.0 (not 2.1+) may also want to check out
> +# lib/middleware/unicorn_oobgc.rb from the Discourse project
> +# (https://github.com/discourse/discourse)
> +#
>  # The following information is only for historical versions of Ruby.
>  #
>  # Runs GC after requests, after closing the client socket and
> _______________________________________________
> Unicorn mailing list - mongrel-unicorn@rubyforge.org
> http://rubyforge.org/mailman/listinfo/mongrel-unicorn
> Do not quote signatures (like this one) or top post when replying
_______________________________________________
Unicorn mailing list - mongrel-unicorn@rubyforge.org
http://rubyforge.org/mailman/listinfo/mongrel-unicorn
Do not quote signatures (like this one) or top post when replying