diff options
| author | Eric Wong <bofh@yhbt.net> | 2023-09-05 06:43:20 +0000 |
|---|---|---|
| committer | Eric Wong <bofh@yhbt.net> | 2024-01-15 01:45:45 +0000 |
| commit | b652fa51c1342496bdcdecca8e567f1fb46c41c9 (patch) | |
| tree | b10a1dd61bdf0c4b253600ab38dbfbc311da93ed /t | |
| parent | 31d0539878b0e2247a4f98bc0241e05d4738e500 (diff) | |
| download | unicorn-b652fa51c1342496bdcdecca8e567f1fb46c41c9.tar.gz | |
kgio is an extra download and shared object which costs users bandwidth, disk space, startup time and memory. Ruby 2.3+ provides `Socket#accept_nonblock(exception: false)' support in addition to `exception: false' support in IO#*_nonblock methods from Ruby 2.1. We no longer distinguish between TCPServer and UNIXServer as separate classes internally; instead favoring the `Socket' class of Ruby for both. This allows us to use `Socket#accept_nonblock' and get a populated `Addrinfo' object off accept4(2)/accept(2) without resorting to a getpeername(2) syscall (kgio avoided getpeername(2) in the same way). The downside is there's more Ruby-level argument passing and stack usage on our end with HttpRequest#read_headers (formerly HttpRequest#read). I chose this tradeoff since advancements in Ruby itself can theoretically mitigate the cost of argument passing, while syscalls are a high fixed cost given modern CPU vulnerability mitigations. Note: no benchmarks have been run since I don't have a suitable system.
Diffstat (limited to 't')
| -rw-r--r-- | t/oob_gc.ru | 3 | ||||
| -rw-r--r-- | t/oob_gc_path.ru | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/t/oob_gc.ru b/t/oob_gc.ru index c253540..224cb06 100644 --- a/t/oob_gc.ru +++ b/t/oob_gc.ru @@ -7,9 +7,6 @@ $gc_started = false # Mock GC.start def GC.start - ObjectSpace.each_object(Kgio::Socket) do |x| - x.closed? or abort "not closed #{x}" - end $gc_started = true end run lambda { |env| diff --git a/t/oob_gc_path.ru b/t/oob_gc_path.ru index af8e3b9..7f40601 100644 --- a/t/oob_gc_path.ru +++ b/t/oob_gc_path.ru @@ -7,9 +7,6 @@ $gc_started = false # Mock GC.start def GC.start - ObjectSpace.each_object(Kgio::Socket) do |x| - x.closed? or abort "not closed #{x}" - end $gc_started = true end run lambda { |env| |